feat(database): add oracle provider integration via python-oracledb#225
Open
david-mamani wants to merge 10 commits intoNevaMind-AI:mainfrom
Open
feat(database): add oracle provider integration via python-oracledb#225david-mamani wants to merge 10 commits intoNevaMind-AI:mainfrom
david-mamani wants to merge 10 commits intoNevaMind-AI:mainfrom
Conversation
Contributor
|
Hi, the build for this PR is not passing yet. Please make the necessary updates, and we’ll review again after that. Thanks! @david-mamani |
ankaisen
requested changes
Jan 14, 2026
pyproject.toml
Outdated
| "sqlmodel>=0.0.27", | ||
| "alembic>=1.14.0", | ||
| "pendulum>=3.1.0", | ||
| "oracledb>=3.4.1", |
Collaborator
There was a problem hiding this comment.
I recommend we do not add oracledb as a default (hard) dependency of the base package. It's fine to keep this as an optional dependency (extra) so only Oracle users pull it in, e.g. pip install memu-py[oracle].
Contributor
Author
There was a problem hiding this comment.
I've refactored pyproject.toml to make oracledb an optional dependency and implemented lazy loading in the source code. Tests are passing locally without the driver installed.
ankaisen
force-pushed
the
feat/oracle-integration
branch
from
10a381d to
96bfd15
Compare
david-mamani
force-pushed
the
feat/oracle-integration
branch
from
96bfd15 to
7e6f54c
Compare
david-mamani
force-pushed
the
feat/oracle-integration
branch
from
f47ff15 to
f4a80cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request implements support for Oracle Database as a storage provider for MemU, addressing the requirements for Track D (External Tool / Database Integration) and Issue #168.
The implementation utilizes the python-oracledb driver in Thin mode to ensure lightweight connectivity without requiring Oracle Instant Client binaries. The architecture strictly follows the design patterns established by the existing PostgreSQL provider to ensure code consistency and maintainability, leveraging SQLAlchemy and SQLModel for typed database interactions.
Technical Implementation
How to Test
The integration includes a validation script that mocks the database engine, allowing verification of the driver logic and repository flow:
Install the required dependency:
uv add oracledb
Run the verification suite:
uv run pytest tests/test_oracle_mock.py
Resolves #168